Petr Heinz

Results 21 comments of Petr Heinz

We have run into this issue during #1133 as well. I've resolved this in one particular test class by backing up the index via reindexing and then reverting it back:...

To me it seems that `services(_test).yml` should be in the `config` root directory, but the `forms.yml` should be inside `services` dir - similarly to [the config structure in `shopsys/framework`](https://github.com/shopsys/shopsys/tree/master/packages/framework/src/Resources/config/). Why...

Having all the files in the `services` directory will prevent you from using wildcard import in the `services.yml` like this: ```yml imports: - { resource: services/*.yml } ``` Keeping the...

Will you, in the same manner, move `parameters.yml`, `parameters.yml.dist`, `parameters_common.yml`, `parameters_test.yml`, `parameters_test.yml.dist`, `parameters_version.yml`, `parameters_version.yml.dist`, `paths.yml` into a new directory `parameters` as well? And maybe the same for all routing-related configs?

@boris-brtan Personally, I would just move the `forms.yml` in to `services`. I don't see reason to change things further without a very good reason and well-thought-out idea. This step would...

We should definitely work on the forms in the admin section. This is a pretty easy to do, has a lot of value and we already know what to do...

As a simple example I can provide these two snippets: ```php if (!$singleOrderPreviewData->getTotalPrice()->getPriceWithoutVat()->equals($orderPreview->getTotalPrice()->getPriceWithoutVat()) || !$singleOrderPreviewData->getTotalPrice()->getPriceWithVat()->equals($orderPreview->getTotalPrice()->getPriceWithoutVat()) || !$singleOrderPreviewData->getTotalPrice()->getVatAmount()->equals($orderPreview->getTotalPrice()->getVatAmount()) ) { throw new TotalPriceMismatchException($singleOrderPreviewData, $orderPreview); } ``` ```php if (!$singleOrderPreviewData->getTotalPrice()->equals($orderPreview->getTotalPrice())) { throw...

That would make sense :+1:

Cool @henzigo! Finally! 🎉

This check proved useful during a project implementation (especially when we've worked with FE API). More work would be needed to cover it with automated tests - specifically extracting the...