Make idempotent install command Ubuntu compatible

[PeterMosmans]

Hi @ijkim88 - in the latest version I added a check that makes sure that all 'extra' installed packages necessary for compiling are removed. I'm not sure if it's Ubuntu complaint. If you have the time, could you check whether this works on Ubuntu ? The Travis CI currently only checks Debian installs. Thanks!

Peter

[ijkim88]

@PeterMosmans - I'll try it out later today when I get the chance.

[ijkim88]

Started testing this but running into some issues with testing on my MBP. I'll get back to you soon.

I did notice that aptitude is required to build the list of installed packages. While testing on Ubuntu's public Vagrant boxes, I noticed the latest trusty64 box has aptitude, but the xenial64 box doesn't for some reason... You may want to note that as a dependency in the meantime.

Also, I'm a CentOS user so I'm hoping it will be supported for this role in the future :)

-Isaac

[fredleger]

Seems to not work at least with latest ansible :

==> default:
==> default: TASK [PeterMosmans.virtualbox-guest : Remove installed packages for compiling] *
==> default: [DEPRECATION WARNING]: Skipping task due to undefined Error, in the future this
==> default:  will be a fatal error.: 'dict object' has no attribute 'stdout_lines'.
==> default: This
==> default: feature will be removed in a future release. Deprecation warnings can be
==> default: disabled by setting deprecation_warnings=False in ansible.cfg.
==> default: skipping: [localhost]
==> default:

[PeterMosmans]

Hi @fredleger - thanks for your feedback. As you can see :arrow_up: I recently changed some stuff which unfortunately breaks on Ubuntu. Watch this space, as this will be fixed soon (in the meanwhile, you could use the previous version or use Debian)

[fredleger]

Another report (i'm doing much testing on ubuntu this time).

Sometimes it can lead to unpredictable packages uninstalls :

TASK [PeterMosmans.virtualbox-guest : Remove installed packages for compiling] *
changed: [localhost] => (item=[u'acl', u'at-spi2-core', u'colord', u'dconf-gsettings-backend', u'dconf-service', u'dkms', u'fontconfig', u'fontconfig-config', u'fonts-dejavu-core', u'hicolor-icon-theme', u'libasound2', u'libasound2-data', u'libatk-bridge2.0-0', u'libatk1.0-0', u'libatk1.0-data', u'libatspi2.0-0', u'libavahi-client3', u'libavahi-common-data', u'libavahi-common3', u'libcairo-gobject2', u'libcairo2', u'libcanberra-gtk3-0', u'libcanberra-gtk3-module', u'libcanberra0', u'libcolord1', u'libcolorhug1', u'libcups2', u'libdatrie1', u'libdconf1', u'libdrm-intel1', u'libdrm-nouveau2', u'libdrm-radeon1', u'libexif12', u'libfontconfig1', u'libfontenc1', u'libgd3', u'libgdk-pixbuf2.0-0', u'libgdk-pixbuf2.0-common', u'libgl1-mesa-dri', u'libgl1-mesa-glx', u'libglapi-mesa', u'libgphoto2-6', u'libgphoto2-l10n', u'libgphoto2-port10', u'libgraphite2-3', u'libgtk-3-0', u'libgtk-3-bin', u'libgtk-3-common', u'libgudev-1.0-0', u'libgusb2', u'libharfbuzz0b', u'libice6', u'libieee1284-3', u'libjasper1', u'libjbig0', u'libjpeg-turbo8', u'libjpeg8', u'liblcms2-2', u'libllvm3.4', u'libltdl7', u'libnotify-bin', u'libnotify4', u'libogg0', u'libpango-1.0-0', u'libpangocairo-1.0-0', u'libpangoft2-1.0-0', u'libpciaccess0', u'libpixman-1-0', u'libsane', u'libsane-common', u'libsm6', u'libtdb1', u'libthai-data', u'libthai0', u'libtiff5', u'libtxc-dxtn-s2tc0', u'libv4l-0', u'libv4lconvert0', u'libvorbis0a', u'libvorbisfile3', u'libvpx1', u'libwayland-client0', u'libwayland-cursor0', u'libx11-xcb1', u'libxaw7', u'libxcb-dri2-0', u'libxcb-dri3-0', u'libxcb-glx0', u'libxcb-present0', u'libxcb-render0', u'libxcb-shm0', u'libxcb-sync1', u'libxcomposite1', u'libxcursor1', u'libxdamage1', u'libxfixes3', u'libxfont1', u'libxi6', u'libxinerama1', u'libxkbcommon0', u'libxkbfile1', u'libxmu6', u'libxpm4', u'libxrandr2', u'libxrender1', u'libxshmfence1', u'libxt6', u'libxtst6', u'libxxf86vm1', u'notification-daemon', u'sound-theme-freedesktop', u'x11-common', u'x11-xkb-utils', u'xfonts-base', u'xfonts-encodings', u'xfonts-utils', u'xserver-common', u'xserver-xorg-core'])

I think it can have a link to packages marked as installed automatically but not sure about that

[PeterMosmans]

Hi @fredleger - thanks for the reports, keep 'em coming :wink: I changed the responsible code, could you please check whether this still is an issue ?

On a side note - I will be adding Ubuntu and CentOS to the Travis tests in the near future, so that not only Debian is properly CI tested.

Thanks once again,

Peter