tor-socks-proxy icon indicating copy to clipboard operation
tor-socks-proxy copied to clipboard

ability to configure user and group id

Open miracle091 opened this issue 2 years ago • 5 comments

technically possible and here is the link of the official documentations i can push a pr for this change, but first what is the best ID for user and group for use by default?

miracle091 avatar Jan 17 '23 16:01 miracle091

Is this trying to solve the container and host user/group id mapping issue?

PeterDaveHello avatar Jan 17 '23 16:01 PeterDaveHello

that and avoid possible (future?) problems with privileges escalation

miracle091 avatar Jan 17 '23 16:01 miracle091

@miracle091 Okay ... I don't very mind that personally, and not sure if privileges escalation issues really exists with it, because that can be a massive issue already?

Anyway, a pull request is still welcome, please just make sure it's not too complex to be understood and used, I'll see how can I merge it. Thanks for the contribution!

PeterDaveHello avatar Jan 17 '23 16:01 PeterDaveHello

about an actual issue i don't know, but for my experience is better have it already ready to use that wait for a fix or a workaround.

the implementation is something that have a default value (like 1000 or others number) and the possibility to modify it using the -e flag if someone need/want it, for most users is just a drop-in and nothing to worry about

miracle091 avatar Jan 17 '23 17:01 miracle091

#48 have done a pr for some minimal changes, during my tests have found that the alpine use a custom user and change it is a real pain. the solutution can be two, for what have seen:

  1. change build image with something else, like debian/ubuntu and derivates
  2. discard my idea and leave everything as it is now

miracle091 avatar Jan 18 '23 09:01 miracle091