django-keycloak icon indicating copy to clipboard operation
django-keycloak copied to clipboard

Add support for keycloak>v4 & Django 4.1.1

Open dabocs opened this issue 3 years ago • 4 comments

  • Added support for keycloak > v17 & Django 4.1.1 (should be Django > v2.0)
  • Fixed issues
    • https://github.com/Peter-Slump/django-keycloak/issues/57
    • https://github.com/oauth2-proxy/oauth2-proxy/issues/1448
  • Updated steps at documentation to fix issue https://github.com/Peter-Slump/django-keycloak/issues/18 based on the answer https://stackoverflow.com/questions/53550321/keycloak-gatekeeper-aud-claim-and-client-id-do-not-match/53627747#53627747
  • This package depends on upgrade PR for KC > v17

dabocs avatar Oct 06 '22 11:10 dabocs

@Peter-Slump Tested on keycloak v18 & v19 & Django 4.1.1

dabocs avatar Oct 06 '22 12:10 dabocs

Hey @dabocs thank you for this PR. Unfortunately as you can understand it seems that @Peter-Slump does not maintain this project any longer.

My recommendation, would be to fork this project using a new name, i.e django-keycloak2, apply your PR and release a new pypi version under the new name (if you are willing of course to commit to ths burden).

Then we can add comments to the corresponding issues pointing to the forked project so users can use it isntead of this.

Thank you

spapas avatar Aug 10 '23 06:08 spapas

Hey @dabocs thank you for this PR. Unfortunately as you can understand it seems that @Peter-Slump does not maintain this project any longer.

My recommendation, would be to fork this project using a new name, i.e django-keycloak2, apply your PR and release a new pypi version under the new name (if you are willing of course to commit to ths burden).

Then we can add comments to the corresponding issues pointing to the forked project so users can use it isntead of this.

Thank you

@spapas Thanks for your advice. I already did that and forked the repo here and I have a pypi package published here

dabocs avatar Aug 10 '23 11:08 dabocs

Thank you very much @dabocs !

spapas avatar Aug 10 '23 12:08 spapas