Do not send notification if failed build is a personal build

[gwin003]

trafficstars

We use Visual Studio pretested commits to TeamCity fairly often, and it would be awesome if this plugin didn't send the notification to slack if the build was a personal one.

[PeteGoo]

Aha! Good point. I've never used them myself. Sounds like a pretty trivial fix if you feel game?

On Fri, 25 Sep 2015 6:20 am Adam Gwin [email protected] wrote:

We use Visual Studio pretested commits to TeamCity fairly often, and it would be awesome if this plugin didn't send the notification to slack if the build was a personal one.

— Reply to this email directly or view it on GitHub https://github.com/PeteGoo/tcSlackBuildNotifier/issues/55.

[gwin003]

Sure, I'll give it a shot sometime this weekend and see what I can do. Thanks! :)

[ghostsquad]

Or better, send the slack notification to the person associated with the personal build.

[BHare1985]

Any progress with this? we are considering to use the teamcity plugin just so we can be able to do this and not have the slack notifier spam us

[nheath]

surprised to see this didn't already work! would love to have this.

[marvin-w]

will implement this after the refactoring (or maybe just with it)

[koerbcm]

+1

[danieljimenez]

+1

[halldorfannar]

Any update on this issue?

[bronumski]

If anyone is up for the challenge I think it is as simple as calling isPersonal on SRunningBuild in SlackNotificationListener private void processBuildEvent(SRunningBuild sRunningBuild, BuildStateEnum state)

http://javadoc.jetbrains.net/teamcity/openapi/9.1/jetbrains/buildServer/serverSide/SRunningBuild.html https://github.com/PeteGoo/tcSlackBuildNotifier/blob/master/tcslackbuildnotifier-core/src/main/java/slacknotifications/teamcity/SlackNotificationListener.java

I would do it but I have not touched java for years and I don't have an environment.