PerthCharern

Results 21 comments of PerthCharern

Define constants for OpenAPI data types and few additions

I'll bundle this change with the fix to #306.

Define constants for OpenAPI data types and few additions

Plan change. To keep the PR size sane, fix will be sent out separately after PR for #306 is checked in.

Server URI is parsed incorrectly when the URI is relative

Thanks for reporting @selman92. V2 spec splits out the URL into multiple parts, including `basePath`, `host` and `schemes`. In V3, these are all combined into the Server Object `url`. Since...

Server URI is parsed incorrectly when the URI is relative

That's true. From a practical standpoint, I agree it makes more sense to just output /v2 as a relative URL. For this case specifically, if you remove the `scheme: -http`...

Server URI is parsed incorrectly when the URI is relative

I would also further argue that there might not be much of a use case to specify scheme if the default host is to be used. I don't think the...

Make PathItem a referenceable object

Could you remind me where PathItem is referenced? Are we talking about the PathItem in the Callback object?

Make PathItem a referenceable object

What do you think about the Operation object? Potentially, it can also be a referenceable object? https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.0.md#linkObject The link object can refer to the Operation by its id.

Make PathItem a referenceable object

And yes, PathItem should also be handled.

Relative server url - V3

I can take a look into this more.

How should I decide which diagnostics are mission-critical?

We don't add severity level to the existing rules because these errors are all spec-violating. In principle, our library should not enforce any standards beyond what the spec requires, so...