Dancer2 icon indicating copy to clipboard operation
Dancer2 copied to clipboard

Feature/engine namespaces 1323

Open veryrusty opened this issue 4 years ago • 5 comments

Draft implementation to allow fully qualified namespaces for all engines, as discussed some time ago in #1323.

Draft PR before I go write more tests / documentation to ensure this is where we want to go:

  set engines => {
    serialier => {
      'My::Awesome::Serializer => { ... },
    },
    template => {
      'My::Template::DWIM => { ... }.
    },
  };
  set serializer => `+My::Awesome::Serializer`;
  set template => `+My::Template::DWIM`;

veryrusty avatar Jan 13 '21 03:01 veryrusty

@SysPete @racke @cromedome thoughts ?

veryrusty avatar Jan 13 '21 03:01 veryrusty

Sounds good to me. :+1:

racke avatar Jan 13 '21 11:01 racke

Just make sure that you don't repeat the serialier typo in the documentation.


 set engines => {
    serialier => {
      'My::Awesome::Serializer => { ... },
    },
    template => {
      'My::Template::DWIM => { ... }.
    },
  };

racke avatar Jan 13 '21 11:01 racke

@veryrusty :+1: for using + as a FQ namespace indicator as it follows a pattern used elsewhere. Very happy to see this, thank you!

SysPete avatar Jan 13 '21 11:01 SysPete

Yes! 👍 I like what you've done here! Please keep running with it.

cromedome avatar Jan 14 '21 03:01 cromedome