Dancer icon indicating copy to clipboard operation
Dancer copied to clipboard

added tests that exhibit issue #980 + fix; also fix #979

Open a-adam opened this issue 10 years ago • 2 comments

content length is miscalculated when the app has no 'charset' setting. adding the pragma 'use bytes' fixes the issue. https://github.com/PerlDancer/Dancer/issues/980

fix https://github.com/PerlDancer/Dancer/issues/979 too.

a-adam avatar Jan 22 '14 22:01 a-adam

... this has sat for far, far, far too long - I'm almost embarassed to comment on it it's been that long - but it appears to contain some important bugfixes.

I'm sorry this hasn't been acted upon for some time. I see that a fix for the content length being miscalculated with UTF-8 got merged, at least, but there's other worthwhile stuff in here. For instance, returning an error if deserialisation fails is obviously sensible - need to check if current devel really does carry on with request processing if deserialisation fails, I find that hard to believe.

So, yes - sorry that this PR has sat unattended to for so long. I'm trying to catch up on outstanding PRs and bug reports as fast as I can now I've taken over as D1 release manager.

I think I'll get a new developer release out to CPAN soon with the stuff I've merged recently, then re-visit this PR to review it in detail and get it merged.

bigpresh avatar Feb 14 '16 22:02 bigpresh

biennial ping :-/

aldot avatar Jul 22 '16 10:07 aldot