Dancer
Dancer copied to clipboard
PerlDancer
Refactoring/script
I've added the -t/--template option to Dancer::Script and updated script/dancer with some usage information.
That's awesome work, thank you!!
Why did you change the template variable syntax to [[ and ]]?
My thinking was that the files within the application template directory may have their own template delimiters (in the "view" files) that may conflict with [% and %] since they are so common and I didn't want the process of generating the application dir from the application template to to accidentally interfere with those files. (i.e. for some files there are two levels of templating, one to create the application dir and the other for application itself)
Perhaps that's a tad overly paranoid though.
Just wanted to make it clear that this isn't being ignored; we're aware of the PR, and I plan to review, test and merge as soon as time permits. A lot of effort is going towards Dancer2, but we obviously still want to maintain and improve Dancer until such time as Dancer2 is ready for a stable release :)
I'll try to conduct a triage today. If I get around to it, I might merge this in, in a few hours. This is definitely not being ignored and thanks for the ping! :)
OK so first review:
-
This includes the full work of Carlos, are we sure everything was done entirely there?
-
I'm experiencing a bug here:
$ perl -Ilib ./script/dancer -a TestFoo debug> Writing directory: TestFoo debug> Successfully wrote the directory: TestFoo Can't locate object method "_jquery_minified" via package "Dancer::Script" at lib/Dancer/Script.pm line 469.
... sorry this has waited so long. This is something we should definitely incorporate in Dancer2.
We're mostly focussing new features on D2 these days, but since this has waited ages as a PR ready to merge, if the issue sukria saw is fixed, I think we should merge it anyway. Thoughts, guys?
There's a branch with all of this work relatively recently rebased. Check that out.
Yanick just merged the branch Sawyer mentions above into devel, so if I am not mistaken this issue can be closed.
EDIT: I was mistaken and this PR with application templates is not yet included. So it's good that issue is not closed. Should it be merged at all? With or without [[ ]] is not quite clear from this thread.
