Dancer

Dancer copied to clipboard

Hi @PerlDancer, please review the above change. Many Thanks. Best Regards, Mohammad S Anwar

manwar

halt() doesn't execute after hooks

6

I have a standard `on_route_exception` hook setup to catch thrown exceptions: ``` perl hook on_route_exception => sub { my ($exc) = @_; error "$exc"; ... stuff halt err $exc->code, $exc->err_id,...

danschmidt5189

When `behind_proxy` is on, `request->address` returns value of `X-Forwarded-For` header, and it's completely legitimate for this header to contain multiple IP addresses: https://developer.mozilla.org/ru/docs/Web/HTTP/Headers/X-Forwarded-For - IP of the client and proxies'...

ichesnokov

forward()ed POST request loses body?

3

Running this simple test case app, which outputs the request body, `forward()`s to another route and outputs the request body again: ```perl #!/usr/bin/env perl use 5.012; use Dancer; use DDP;...

bigpresh

Response is serialized before `before_serializer` hook is called

2

When we at our action do `send_error { some => 'error' }` the `$response->content` is serialized before `before_serializer` hook is called: https://github.com/PerlDancer/Dancer/blob/dc9df8b5afb37331fdf9ecf0b3a387d95cc2d39a/lib/Dancer/Renderer.pm#L199 ```perl sub serialize_response_if_needed { my $response = Dancer::SharedData->response();...

KES777

It seems Dancer do useless things if `$content` is returned by `$self->execute` (send_error) ```diff --- a/lib/Dancer/Route.pm +++ b/lib/Dancer/Route.pm @@ -200,7 +200,15 @@ sub run { Dancer::Factory::Hook->execute_hooks('on_route_exception', $exception); die $exception; };...

KES777

Typo at documentation

1

It is [here](https://metacpan.org/pod/Dancer#halt) ``` hook before sub { if ($some_condition) { halt("Unauthorized"); # This code is not executed : do_stuff(); } }; get '/' => sub { "hello there"; };...

KES777

send_error do not setup response code for hook callbacks

1

When we call `send_error 418, { some => 'error' }` Next code is executed: ```perl 1>203: sub send_error { Dancer::Continuation::Route::ErrorSent->new( 204: return_value => Dancer::Error->new( 205: message => $_[0], 206: code...

KES777

Dancer::Cookie and sameSite attribute

8

Firefox started to complain in developer console that: > Cookie “some_session” will be soon rejected because it has the “sameSite” attribute set to “none” or an invalid value, without the...

isync

I have a test app that gets a request with a URL in which the escaping/encoding in the URL is in lower case (eg. %2f instead of %2F). The nature...

timlegge