hints/openbsd.sh: retain commented-out lines?

[jkeenan]

In hints/openbsd.sh, we entered the following comments and statement as per $ git blame

$ git blame -L 153,157 -- hints/openbsd.sh
83f3439aaa8 (Karl Williamson 2019-04-03 14:27:00 -0600 153) # openbsd has a problem regarding newlocale()
83f3439aaa8 (Karl Williamson 2019-04-03 14:27:00 -0600 154) # https://marc.info/?l=openbsd-bugs&m=155364568608759&w=2
83f3439aaa8 (Karl Williamson 2019-04-03 14:27:00 -0600 155) # which is being fixed.  In the meantime, forbid POSIX 2008 locales
418ebdf9639 (Karl Williamson 2023-07-09 07:52:26 -0600 156) #d_newlocale="$undef"
83f3439aaa8 (Karl Williamson 2019-04-03 14:27:00 -0600 157) 

Originally, (i.e., in 2019) d_newlocale was assigned "$undef". When we became satisfied that the problem upstream had been addressed, we deactivated line 156 by commenting it out. Now, on (my admittedly obsolete OpenBSD-6.9 VM), when I run sh ./Configure, I get:

$ grep -n d_newlocale config.sh
428:d_newlocale='define'

Which appears to be working satisfactorily.

My question is: Do we need to retain any of the 4 commented-out lines above in hints/openbsd.sh?

Relevant URLs: openbsd-bugs mailing list thread beginning at https://marc.info/?l=openbsd-bugs&m=155364568608759&w=2

discussion on a POSIX bug tracker cited in above thread: https://austingroupbugs.net/view.php?id=1243

@khwilliamson @afresh1 @tonycoz

[afresh1]

I do have some patches I should push upstream, although it's the same on a fairly recent OpenBSD snapshot.

$ grep -n d_newlocale config.sh
428:d_newlocale='define'

• https://github.com/afresh1/OpenBSD-perl/blob/blead/patches/GOOD/has_big_time.patch
• https://github.com/afresh1/OpenBSD-perl/blob/blead/patches/GOOD/UPSTREAM/no-tree-ter-for-alpha.patch
• https://github.com/afresh1/OpenBSD-perl/blob/blead/patches/GOOD/remove_pthread_util_from_libswanted.patch
• https://github.com/afresh1/OpenBSD-perl/blob/blead/patches/GOOD/UPSTREAM/use_vax_atof.patch#L4 (although we don't actually run on vax anymore)
• https://github.com/afresh1/OpenBSD-perl/blob/blead/patches/GOOD/no_locale_collate_or_numeric.patch
• https://github.com/afresh1/OpenBSD-perl/blob/blead/patches/GOOD/UPSTREAM/correct_fpic.patch

[jkeenan]

I do have some patches I should push upstream, although it's the same on a fairly recent OpenBSD snapshot.

* https://github.com/afresh1/OpenBSD-perl/blob/blead/patches/GOOD/no_locale_collate_or_numeric.patch

I should note that since Dec 20 2023, we've had the following entry in blead's hints/openbsd.sh:

e622e0481be (Karl Williamson     2023-12-14 21:57:29 -0700 159) ccflags="$ccflags -DNO_LOCALE_NUMERIC -DNO_LOCALE_COLLATE -DNO_LOCALE_MONETARY -DNO_LOCALE_TIME -DNO_LOCALE_MESSAGES"

[afresh1]

I will probably drop that patch then :-) I don't think we need both

[afresh1]

Also, the patch in the linked email thread has been in since 2019 and OpenBSD only supports releases for 1 year (well, the two previous releases, with two releases per year, so 1 year, usually plus a month), so I think we are safe to remove that line.