perl5 icon indicating copy to clipboard operation
perl5 copied to clipboard

Make some similar functions use same parameter names with same constness

Open khwilliamson opened this issue 1 year ago • 1 comments

An advantage of combining API elements that do almost the same thing into a single group, is that disparities in their signatures become much more visible. These are typically harmless, but sloppy practice. These two commits fix a couple of those cases sv_catpv and sv_catsv

khwilliamson avatar Jul 29 '24 21:07 khwilliamson

SV * const dsv as argument type doesn't really make sense as an argument type. That const doesn't actually affect the interface.

Leont avatar Jul 30 '24 20:07 Leont

I checked, and there are about 400 instances in embed.fnc of the same type of declaration

khwilliamson avatar Sep 01 '24 21:09 khwilliamson

I checked, and there are about 400 instances in embed.fnc of the same type of declaration

Fair. I don't like it but don't let that stop you from merging it.

Leont avatar Sep 02 '24 23:09 Leont

It can make things look "safer" than they are; I agree

khwilliamson avatar Sep 02 '24 23:09 khwilliamson