perl5 icon indicating copy to clipboard operation
perl5 copied to clipboard

Update perldata.pod else everybody will think sigil=$

Open jidanni opened this issue 1 year ago • 5 comments

No matter all my life I thought "Sigil" only meant "$".

It's not because "S" looks like "$", it was because of this one sided example!

Well, no more discrimination allowed in this sentence. Equal opportunity for all!

jidanni avatar Jul 26 '24 04:07 jidanni

Haha, cool!

rwp0 avatar Jul 26 '24 10:07 rwp0

The section of the document you're patching is about special variables that don't obey normal parsing rules. I don't think @1 is a useful example (since it's in *1 as reserved by regex match vars)

You might be better served to add a "sigils" heading above the paragraphs that explain each sigil, then add a heading for each sigil above each paragraph...

guest20 avatar Jul 26 '24 13:07 guest20

Personally I also didn't want to "send the other two children home" in order to "replace them with members of underrepresented groups."

So... please anybody fix this page one way or another. Any way is fine with me. As far as me editing my edit... that would make a Git Mess surely. So please just change the page as you see fit. Thanks.

jidanni avatar Jul 27 '24 01:07 jidanni

What's all this about children?

guest20 avatar Jul 28 '24 19:07 guest20

There were three items. I didn't want to add more items, so I changed two of the three.

jidanni avatar Jul 29 '24 14:07 jidanni

Agreed that the PR as-is doesn't make sense. @1 and %10000 are not special variables (AFAIK).

A bit earlier than the proposed change, there's the sentence:

Additionally, if the identifier is preceded by a sigil -- that is, if the identifier is part of a variable name -- it may optionally be enclosed in braces.

How about we change that to something like the following?

Additionally, if the identifier is preceded by a sigil -- that is, if the identifier is part of a variable name -- it may optionally be enclosed in braces. For example, ${name}, @{bigcats}, %{pizza_toppings}.

richardleach avatar Nov 27 '24 01:11 richardleach

Agreed that the PR as-is doesn't make sense. @1 and %10000 are not special variables (AFAIK).

A bit earlier than the proposed change, there's the sentence:

Additionally, if the identifier is preceded by a sigil -- that is, if the identifier is part of a variable name -- it may optionally be enclosed in braces.

How about we change that to something like the following?

Additionally, if the identifier is preceded by a sigil -- that is, if the identifier is part of a variable name -- it may optionally be enclosed in braces. For example, ${name}, @{bigcats}, %{pizza_toppings}.

@richardleach, If you want to submit a p.r. reflecting your observations above, please do so. Otherwise, since the original p.r. proposal has not won any support, I'm going to close this ticket within 7 days. Thanks.

jkeenan avatar Dec 01 '24 00:12 jkeenan

This PR superseded by https://github.com/Perl/perl5/pull/22841. Thanks all.

richardleach avatar Dec 05 '24 22:12 richardleach