class.c: clean up any state if we don't finish the class

[tonycoz]

Fixes #22169

[jkeenan]

@leonerd, could you please review this p.r. from @tonycoz? Thanks.

[jkeenan]

@tonycoz do you have a feeling for whether or not we're going to be able to merge this pull request into blead in this dev cycle or not? If not, then I recommend we label it 'defer-next-dev'.

[tonycoz]

It's not going anywhere until @leonerd looks at it

[ap]

@leonerd Ping?

[tonycoz]

I haven't read in detail the large changes to Perl_class_seal_stash() but I presume this is mostly just a re-indentation exercise with no change besides invoking the new cleanup function in the failure case.

Yes, Except for some re-wrapping it's just indentation, the github diff viewer has an option to ignore whitespace which is handy for changes like this:

[tonycoz]

I have read the new .t file about four times and I imagine it's supposed to invoke a compiletime error in the eval STR but I can't see what the error is supposed to be. Could it be made clearer there?

There's no closing }, I'll add a comment.

[tonycoz]

Squashed the two commits since it didn't seem worth messing with adding to the first commit and dealing with the conflicts in moving the code to the new function.