perl5 Make local $h{$k} remove previously non-existing key from shared hashes

Make local $h{$k} remove previously non-existing key from shared hashes

Open Leont opened this issue 1 year ago • 5 comments

This is a fix for https://github.com/Perl/perl5/issues/22250

May 29 '24 17:05 Leont

@mauke, do you have any further comment on this pull request? @Leont, assuming this is okay with him, do you want to proceed to merge? Thanks.

Jul 03 '24 11:07 jkeenan

I feel like I don't know enough to 100% positively approve this, but I have no objections. (And Tony already approved it, so it looks fine to me.)

Jul 03 '24 11:07 mauke

I feel like I don't know enough to 100% positively approve this, but I have no objections. (And Tony already approved it, so it looks fine to me.)

It would be good if we could get one more pair of eyeballs on this change in an XS file.

Jul 16 '24 12:07 jkeenan

I should probably add a few comments to make things clearer.

Jul 21 '24 22:07 Leont

I should probably add a few comments to make things clearer.

@Leont could you follow up on adding those clarifying comments? Thanks.

Aug 27 '24 19:08 jkeenan

@Leont Can you please do that?

@jkeenan Speaking for the PSC, once that is done, this can be merged.

Apr 24 '25 16:04 ap