perl5 icon indicating copy to clipboard operation
perl5 copied to clipboard

Simplify `use VERSION behaviour` on 5.37 onwards

Open leonerd opened this issue 2 years ago • 6 comments

(this description was all wrong but in any case I've now reverted it to a draft. We'll wait for 5.39 to apply it properly. I'll write something better by then)

leonerd avatar Mar 19 '23 22:03 leonerd

There are two «if (shortver >= SHORTVER(5, 35))»s in there, can't they be merged?

Leont avatar Mar 19 '23 23:03 Leont

There are two «if (shortver >= SHORTVER(5, 35))»s in there, can't they be merged?

They could, but that might make the logic harder to read. At the moment, there's a clear split between "fiddling with strict bits", followed by "apply warnings".

leonerd avatar Mar 20 '23 10:03 leonerd

Actually this doesn't fix any back-compat. It just adds new behaviour. Probably best to save it for .39 after all.

leonerd avatar Mar 20 '23 11:03 leonerd

@leonerd, this p.r. now has merge conflicts. Do you want to resolve those -- or would it be better to start fresh with a new p.r.?

jkeenan avatar Aug 01 '23 00:08 jkeenan

Resolved conflicts and repushed; retargeted for 5.39 instead.

leonerd avatar Aug 01 '23 18:08 leonerd

@leonerd, this pull request has been in draft status for 12 months and has merge conflicts for 6 months. If you intend to move forward with it, could you resolve conflicts, remove the draft status and re-push? Thanks.

jkeenan avatar Aug 03 '24 11:08 jkeenan