perl5 icon indicating copy to clipboard operation
perl5 copied to clipboard

Small docs clarification on MRO resolve function

Open leonerd opened this issue 2 years ago • 5 comments

Points out that the linear MRO function returns a list of strings.

Before this it wasn't clear to me whether it's a list of string names, or actual HV pointers to stashes.

leonerd avatar Sep 14 '22 12:09 leonerd

Good plan. Updated. (Should squash before merge)

leonerd avatar Sep 14 '22 13:09 leonerd

There's two entries in mro_core.c: mro_get_linear_isa as well as mro_get_linear_isa_dfs, and I just noticed there's mro_get_linear_isa_c3 in ext/mro/mro.xs.

Maybe the MRO-specific ones shouldn't have all the details, and just link to mro_get_linear_isa or perlmroapi?

ilmari avatar Sep 14 '22 14:09 ilmari

Eh; I don't feel like a big docs rewrite at this point. This is a 4th(?)-level dependency of something I happen to be working on. I'll just add that they're strings, to each of the locations.

leonerd avatar Sep 16 '22 14:09 leonerd

Ugh, if I update ext/mro/mro.xs then Porting/cmp_version.t gets upset that I didn't bump the version number. I'm not sure I want to bump a version number purely to add a tiny clarification note on the docs of a function almost nobody cares about :P

leonerd avatar Sep 16 '22 16:09 leonerd

I'm not sure I want to bump a version number purely to add a tiny clarification note on the docs of a function almost nobody cares about :P

Are version numbers that expensive? ;-P

ilmari avatar Sep 16 '22 18:09 ilmari

I updated the version and force pushed this with a better formatted commit message.

demerphq avatar Feb 08 '23 03:02 demerphq