perl5 icon indicating copy to clipboard operation
perl5 copied to clipboard

Math-Complex: correct typos in documentation

Open pjacklam opened this issue 2 years ago • 3 comments

  • Correct typo where "pi" should be "phi".

  • Spherical coordinates should use the same order of the coordinates everywhere, i.e., rho, theta, phi.

pjacklam avatar Sep 01 '22 16:09 pjacklam

This fixes CPAN RT #136653.

pjacklam avatar Sep 01 '22 16:09 pjacklam

This distribution is maintained on CPAN, though permissions have been transferred to P5P, it would need to be moved from cpan/ to dist/ before changes can be made to it in blead.

Grinnz avatar Sep 01 '22 16:09 Grinnz

requires https://github.com/Perl/perl5/pull/20215

Grinnz avatar Sep 01 '22 21:09 Grinnz

Can we have someone handle the content of this pull

  • Correct typo where "pi" should be "phi".

    • Spherical coordinates should use the same order of the coordinates everywhere, i.e., rho, theta, phi.

Can we have someone handle the content of this pull request?

(I or someone else can handle the rebasing, etc., separately once the content is approved.)

jkeenan avatar Oct 01 '22 14:10 jkeenan

Having wrapped my head around the Wikipedia article on spherical coordinates -- specifically, around the sidebar on Spherical coordinates (r, θ, φ) as often used in mathematics: -- I believe this patch is correct and should be applied. I will do so within 7 days unless there is some objection.

jkeenan avatar Dec 25 '22 22:12 jkeenan

@jkeenan : the changes look right to me too (and I studied that in the Technion).

shlomif avatar Dec 26 '22 05:12 shlomif

Personally I think @Grinnz has a point. I dont think we need to be as strict as he says, we can patch it in cpan/ and THEN move it to dist, provided we actually move it to dist/ in the end.

demerphq avatar Dec 26 '22 10:12 demerphq

OH, we have already moved it to dist.

demerphq avatar Dec 26 '22 12:12 demerphq

@jkeenan why wait?

demerphq avatar Dec 26 '22 12:12 demerphq

@jkeenan why wait?

Among other reasons ... at this time of year many people are not reading their email. So giving people (including the OP) a time frame in which to respond does not hurt.

(I could give other reasons, but then we would be deep into a policy discussion which should take place on the perl5-porters mailing list.)

jkeenan avatar Dec 27 '22 12:12 jkeenan

Handled manually and merged to blead in 7b4ead7ffc. Closing ticket.

jkeenan avatar Dec 29 '22 21:12 jkeenan