perl5 icon indicating copy to clipboard operation
perl5 copied to clipboard

toke.c - dont just return the function, assign it to an intermediary

Open demerphq opened this issue 3 years ago • 2 comments

So we can debug it before we return. an optimization compiler should make them the same thing anyway, but under -Og it is helpful to be able to be able to see the return before we return it.

demerphq avatar Aug 29 '22 19:08 demerphq

This seems like the type of change I might make temporarily rather than something to commit.

Assuming finish didn't do what I wanted.

tonycoz avatar Aug 31 '22 05:08 tonycoz

On Wed, 31 Aug 2022 at 07:01, Tony Cook @.***> wrote:

This seems like the type of change I might make temporarily rather than something to commit.

Well, personally i dont see why we wouldn't make it permanent. If it got used to debug this once then why not again in the future? My experience is the past tends to repeat itself.... What would the harm be?

Yves

-- perl -Mre=debug -e "/just|another|perl|hacker/"

demerphq avatar Aug 31 '22 05:08 demerphq

an optimization compiler should make them the same thing anyway

Indeed. And trivial to confirm with godbolt if you wish.

ericherman avatar Dec 30 '22 19:12 ericherman