perl5 icon indicating copy to clipboard operation
perl5 copied to clipboard

Document postderef_qq support for ->$#* interpolation

Open zmughal opened this issue 3 years ago • 1 comments

This was added in commit https://github.com/Perl/perl5/commit/ff25e5dbbad6ccf83f2e2a874a3c90294ea8cb47.

zmughal avatar Aug 05 '22 22:08 zmughal

The English style of the changes is now good. But I'd like someone else to review the content of the changes, as I myself have never used this Perl syntax. @rjbs perhaps?

jkeenan avatar Aug 06 '22 23:08 jkeenan

This addition is needed, but it is misleading. The number returned is related to the array length, but it is one off. The number returned is the index of the highest element in the array. So if the array has 10 elements, 0..9, this returns 9. This needs to be clarified

khwilliamson avatar Nov 21 '22 04:11 khwilliamson

I have updated the text again with @khwilliamson's suggestions. I think I might need to do a rebase again?

zmughal avatar Nov 23 '22 17:11 zmughal

Unfortunately, use of the word 'last' is ambiguous. It can mean the previous, or the final. I suggest using 'highest' instead.

I don't think rebasing is required at this point.

khwilliamson avatar Nov 29 '22 19:11 khwilliamson

Thanks

This was merged via 365f3e0f038557f283dc48f11d9dd1d2eb0dfb8b

khwilliamson avatar Nov 30 '22 15:11 khwilliamson