perl5
perl5 copied to clipboard
Perl
Use ppport.h when building dist/ modules in core
By always including ppport.h, this simplifies both XS code and tooling around it.
This is an alternative to #19888 (and as such we probably should finish the discussion there).
Something similar to this should probably be done to some of the modules in cpan/ (IPC-SysV, Scalar-List-Util, Compress-Raw-ZLib, Compress-Raw-Bzip2, Sys-Syslog), and threads.pm needs a bit of refactoring to simplify further.
By always including
ppport.h, this simplifies both XS code and tooling around it.This is an alternative to #19888 (and as such we probably should finish the discussion there).
Something similar to this should probably be done to some of the modules in
cpan/(IPC-SysV, Scalar-List-Util, Compress-Raw-ZLib, Compress-Raw-Bzip2, Sys-Syslog), and threads.pm needs a bit of refactoring to simplify further.
This p.r. has received two review approvals but has not yet been merged. Was some new problem spotted? If not, can we merge?
Thank you very much. Jim Keenan
@jkeenan I think we are deadlocked with #19888. Some folks think we should just always use ppport.h in core, and some folks think we shouldn't use it at all. There are no explicit approves for #19888 and two for this. At the very least @atoomic preferred the alternative and @haarg wrote #19888 so presumably he favors it as well.
@jkeenan I think we are deadlocked with #19888. Some folks think we should just always use ppport.h in core, and some folks think we shouldn't use it at all. There are no explicit approves for #19888 and two for this. At the very least @atoomic preferred the alternative and @haarg wrote #19888 so presumably he favors it as well.
This pull request has languished since last August and has developed merge conflicts. @LeonT, if you would like to move this forward, could you resolve the merge conflicts? (Otherwise, I think we should close the ticket for lacking consensus.) Thanks.
I really would prefer we build core as similarly to how we would build the modules directly from cpan, so I think this is the right patch.
I really would prefer we build core as similarly to how we would build the modules directly from cpan
This would also be my agenda. However we achieve it is fine with me.
We have +3 votes for this PR over #19888 so I am merging this and closing that.
On Wed, Feb 22, 2023 at 12:56:46AM -0800, Yves Orton wrote:
Merged #20006 into blead.
This commit produces some noise on stderr. In particular,
In file included from ../../perl.h:28, from Storable.xs:16: ppport.h:11564:26: warning: ‘DPPP_dummy_PL_parser’ defined but not used [-Wunused-variable]
In file included from ../../perl.h:28, from HiRes.xs:19: ppport.h:11564:26: warning: ‘DPPP_my_ck_warner’ defined but not used [-Wunused-function]
-- This is a great day for France! -- Nixon at Charles De Gaulle's funeral
On Sat, 25 Feb 2023 at 14:10, iabyn @.***> wrote:
On Wed, Feb 22, 2023 at 12:56:46AM -0800, Yves Orton wrote:
Merged #20006 into blead.
This commit produces some noise on stderr. In particular,
In file included from ../../perl.h:28, from Storable.xs:16: ppport.h:11564:26: warning: ‘DPPP_dummy_PL_parser’ defined but not used [-Wunused-variable]
I didnt notice that one yet.
In file included from ../../perl.h:28, from HiRes.xs:19: ppport.h:11564:26: warning: ‘DPPP_my_ck_warner’ defined but not used [-Wunused-function]
Just pushed a fix for this one in https://github.com/Perl/perl5/pull/20853
cheers, Yves
-- perl -Mre=debug -e "/just|another|perl|hacker/"
On Sat, 25 Feb 2023 at 14:14, demerphq @.***> wrote:
In file included from ../../perl.h:28,
from Storable.xs:16: ppport.h:11564:26: warning: ‘DPPP_dummy_PL_parser’ defined but not used [-Wunused-variable]
Fix pushed as https://github.com/Perl/perl5/pull/20854
Yves