perl5 icon indicating copy to clipboard operation
perl5 copied to clipboard

Smoke me/jkeenan/parsexs gh19661 20220704

Open jkeenan opened this issue 3 years ago • 1 comments

jkeenan avatar Jul 04 '22 15:07 jkeenan

This p.r. responds (somewhat) to the issues raised in https://github.com/Perl/perl5/issues/19661. The first commit is adapted from a test file suggested by @choroba in that ticket; the other commits are my extensions of that line of thought.

This p.r. does add a print-out of a TODO test when you run make test_harness. That's aesthetically displeasing to me, especially since I can't predict when that test would PASS and therefore be un-TODO-able. So I'm not going to fight to the death for this p.r. to be merged. If it's not accepted in a reasonable period of time, I'll withdraw it.

jkeenan avatar Sep 16 '22 22:09 jkeenan

This p.r. responds (somewhat) to the issues raised in #19661. The first commit is adapted from a test file suggested by @choroba in that ticket; the other commits are my extensions of that line of thought.

This p.r. does add a print-out of a TODO test when you run make test_harness. That's aesthetically displeasing to me, especially since I can't predict when that test would PASS and therefore be un-TODO-able. So I'm not going to fight to the death for this p.r. to be merged. If it's not accepted in a reasonable period of time, I'll withdraw it.

I will close this pull request within 14 days unless we get additional support for committing it.

jkeenan avatar Nov 05 '22 20:11 jkeenan

I think this should be merged. The underlying problem is a bit tricky, but imo we should deal with it more gracefully than we do.

demerphq avatar Nov 06 '22 10:11 demerphq