perl5
perl5 copied to clipboard
Smoke me/jkeenan/parsexs gh19661 20220704
This p.r. responds (somewhat) to the issues raised in https://github.com/Perl/perl5/issues/19661. The first commit is adapted from a test file suggested by @choroba in that ticket; the other commits are my extensions of that line of thought.
This p.r. does add a print-out of a TODO test when you run make test_harness. That's aesthetically displeasing to me, especially since I can't predict when that test would PASS and therefore be un-TODO-able. So I'm not going to fight to the death for this p.r. to be merged. If it's not accepted in a reasonable period of time, I'll withdraw it.
This p.r. responds (somewhat) to the issues raised in #19661. The first commit is adapted from a test file suggested by @choroba in that ticket; the other commits are my extensions of that line of thought.
This p.r. does add a print-out of a TODO test when you run
make test_harness. That's aesthetically displeasing to me, especially since I can't predict when that test would PASS and therefore be un-TODO-able. So I'm not going to fight to the death for this p.r. to be merged. If it's not accepted in a reasonable period of time, I'll withdraw it.
I will close this pull request within 14 days unless we get additional support for committing it.
I think this should be merged. The underlying problem is a bit tricky, but imo we should deal with it more gracefully than we do.