perl5 icon indicating copy to clipboard operation
perl5 copied to clipboard

Remove obsolete functions from util.c

Open khwilliamson opened this issue 3 years ago • 2 comments

A few functions, get_ppaddr() being one, were added as a workaround for issues on some platforms, which have long been fixed. The functions should be removed, by deprecating their use first, and following through later. @nwc10 started work on this some time ago; this ticket reminds us to pursue it.

`

khwilliamson avatar May 15 '22 18:05 khwilliamson

A few functions, get_ppaddr() being one, were added as a workaround for issues on some platforms, which have long been fixed. The functions should be removed, by deprecating their use first, and following through later. @nwc10 started work on this some time ago; this ticket reminds us to pursue it.

`

@nwc10, @khwilliamson, Do we have a branch that holds that earlier work?

jkeenan avatar Jun 28 '22 00:06 jkeenan

A few functions, get_ppaddr() being one, were added as a workaround for issues on some platforms, which have long been fixed. The functions should be removed, by deprecating their use first, and following through later. @nwc10 started work on this some time ago; this ticket reminds us to pursue it. `

@nwc10, @khwilliamson, Do we have a branch that holds that earlier work?

@nwc10, @khwilliamson, same questions as above ^^

jkeenan avatar Sep 21 '22 22:09 jkeenan

They are already deprecated by a5f200dfe4c. Compilers that notice attribute__deprecated will generate a build-time warning every time any is used. I'm uncertain if that is sufficient for 5.38.

The next step would be to just pull the functions after a suitable deprecation period. Or cause the first instance in a program of calling one of them to raise a default-on warning, saying that this module won't work after release X. Then users of the affected modules could pressure the maintainers to fix things.

Or make them macros (at least temporarily) that don't take up space unless someone actually uses them

khwilliamson avatar Oct 28 '22 03:10 khwilliamson

A few functions, get_ppaddr() being one, were added as a workaround for issues on some platforms, which have long been fixed. The functions should be removed, by deprecating their use first, and following through later. @nwc10 started work on this some time ago; this ticket reminds us to pursue it.

`

@khwilliamson I think we would be better off opening one GH issue (or pull request) for each of the obsolete functions still remaining in util.c. Would you be able to open some of these more specific tickets?

jkeenan avatar Jul 11 '23 15:07 jkeenan