perl5 icon indicating copy to clipboard operation
perl5 copied to clipboard

regcomp.c: remove experimental status from variable length lookbehind

Open demerphq opened this issue 3 years ago • 3 comments

Remove experimental status for lookbehind. This patch should not be applied until https://github.com/Perl/perl5/pull/19442 is merged.

demerphq avatar Feb 23 '22 03:02 demerphq

As I noted elsewhere, I'm not convinced this has had the level of testing out there to justify marking it non-experimental. However I'm unclear on what the criteria really are for that decision, I've no problem with others deciding differently.

The alternative of reducing the scope sounds more attractive to me, I'll try to look at that.

hvds avatar Feb 26 '22 16:02 hvds

@demerphq is it safe to assume this PR should be closed now, since the alternative to reduce scope of the experimental status has been merged?

hvds avatar Mar 03 '22 15:03 hvds

Please keep it, I will push a new set of commits to do the same thing this branch but on top of the reduced scope patch. I didnt get around to it today.

cheers, yves

On Thu, 3 Mar 2022 at 16:28, Hugo van der Sanden @.***> wrote:

@demerphq https://github.com/demerphq is it safe to assume this PR should be closed now, since the alternative to reduce scope of the experimental status has been merged?

— Reply to this email directly, view it on GitHub https://github.com/Perl/perl5/pull/19454#issuecomment-1058157412, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZ5RZAPFYZSBO5MDUQZYDU6DLC5ANCNFSM5PDGRMRQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

-- perl -Mre=debug -e "/just|another|perl|hacker/"

demerphq avatar Mar 03 '22 15:03 demerphq

I am closing this. The existing documentation is good enough I think. If we want to remove its experimental status we probably have to come up with a new experiment category, and this PR does not do that.

demerphq avatar Feb 08 '23 09:02 demerphq