perl5 icon indicating copy to clipboard operation
perl5 copied to clipboard

Change INSTALL to note that "changes in the Perl language" are usually minor

Open nwc10 opened this issue 4 years ago • 6 comments

The paragraph starts:

On a related issue, old modules may possibly be affected by the changes in the Perl language in the current release.

Previously it made no indication about whether these changes were frequent or rare, small or large. The reality is that we are careful to keep them small and backwards compatible, whenever possible. So add the text:

We try hard to make new features "opt-in", such that existing code will work unchanged, and attempt to identify where bug fixes might expose code which was relying on incorrect interpreter behaviour.

nwc10 avatar Oct 11 '21 18:10 nwc10

The last two sentences regarding perllocal and autobundle should probably be split to their own paragraph now. Or removed, as both of them are rather outdated and unsupported mechanisms.

Grinnz avatar Oct 11 '21 18:10 Grinnz

ExtUtils::Installed is a slightly more supported way to get a list of the currently installed modules, though it relies on packlists and has a few issues related to module-vs-distribution logic, and doesn't have a commandline interface.

Grinnz avatar Oct 11 '21 18:10 Grinnz

The last two sentences regarding perllocal and autobundle should probably be split to their own paragraph now. Or removed, as both of them are rather outdated and unsupported mechanisms.

We should decide whether we're going to move forward with this older p.r. modifying INSTALL.

@nwc10, would you like to provide some feedback on @Grinnz's comments?

jkeenan avatar Mar 02 '22 13:03 jkeenan

I requested from Andreas on this. I mean @andk of course.

demerphq avatar Mar 12 '22 09:03 demerphq

Thanks for bringing this to my attention. Autobundle is neither broken nor unsupported, I use it regularly. I'm not even aware of a convenient alternative. Perllocal is a different cattle of fish: if I remember correctly, it's older than autobundle and since I never use it, I'm not familiar anymore with it's strengths and weaknesses.

andk avatar Mar 12 '22 16:03 andk

IMO we should merge this as is, and then push a follow up PR to split up the paragraphs.

LGTM.

demerphq avatar Mar 12 '22 16:03 demerphq

Hi Andreas,

This was the thread/patch I was wondering if you could review. @Grinnz (Dan Book) says that autobundle is no longer supported. @nwc10 (Nicholas Clark) included a reference to it in a patch to INSTALL. The patch is stalled, and @jkeenan (James Keenan) is trying to find a way forward. Maybe you could clarify the situation for us?

https://github.com/Perl/perl5/pull/19185

Cheers, yves

On Wed, 2 Mar 2022 at 14:36, James E Keenan @.***> wrote:

The last two sentences regarding perllocal and autobundle should probably be split to their own paragraph now. Or removed, as both of them are rather outdated and unsupported mechanisms.

We should decide whether we're going to move forward with this older p.r. modifying INSTALL.

@nwc10 https://github.com/nwc10, would you like to provide some feedback on @Grinnz https://github.com/Grinnz's comments?

— Reply to this email directly, view it on GitHub https://github.com/Perl/perl5/pull/19185#issuecomment-1056939654, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZ5R64QXWOASXBN3YCSN3U55VHBANCNFSM5FYZ42WA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- perl -Mre=debug -e "/just|another|perl|hacker/"

demerphq avatar Oct 11 '22 08:10 demerphq

Hi Andreas, This was the thread/patch I was wondering if you could review. @Grinnz (Dan Book) says that autobundle is no longer supported. @nwc10 (Nicholas Clark) included a reference to it in a patch to INSTALL. The patch is stalled, and @jkeenan (James Keenan) is trying to find a way forward. Maybe you could clarify the situation for us? #19185 Cheers, yves On Wed, 2 Mar 2022 at 14:36, James E Keenan @.> wrote: The last two sentences regarding perllocal and autobundle should probably be split to their own paragraph now. Or removed, as both of them are rather outdated and unsupported mechanisms. We should decide whether we're going to move forward with this older p.r. modifying INSTALL. @nwc10 https://github.com/nwc10, would you like to provide some feedback on @Grinnz https://github.com/Grinnz's comments? — Reply to this email directly, view it on GitHub <#19185 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZ5R64QXWOASXBN3YCSN3U55VHBANCNFSM5FYZ42WA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.Message ID: @.> -- perl -Mre=debug -e "/just|another|perl|hacker/"

There's been no discussion in this older pull request since October. @nwc10, do you still want to proceed with it? (Otherwise, I think we should close it.)

jkeenan avatar Jan 17 '23 14:01 jkeenan

I have rebased this and split the paragraph as requested by @Grinnz. I believe it should be merged.

demerphq avatar Feb 08 '23 07:02 demerphq