perl5 icon indicating copy to clipboard operation
perl5 copied to clipboard

Published 20 hours ago • verified publisher icon Perl

Msys2 upstream

Open Corion opened this issue 4 years ago • 12 comments

This incorporates changes from https://github.com/msys2/MSYS2-packages/blob/master/perl/perl.cygwin-Win32.patch into Perl.

I've split up the PR into several commits to make reviewing easier hopefully. Also, hopefully, bisecting a problem points more closely to the problem than one large patch.

There are separate .patchfiles for Configure which I did not apply or touch (yet)

Corion avatar Jan 18 '21 18:01 Corion

FYI porting/manifest.t is failing right now.

toddr avatar Jan 18 '21 19:01 toddr

FYI porting/manifest.t is failing right now.

Yeah, dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/msys.pm needs to be added to MANIFEST

Leont avatar Jan 18 '21 19:01 Leont

If the two files are exactly identical then we could do with inheritance. They should be fairly similar environments anyway.

Corion avatar Feb 06 '21 21:02 Corion

Probably #18534 needs to be merged before this one.

Leont avatar Feb 07 '21 00:02 Leont

@corion this ticket is stalled and in conflict. Do you have any intention to rebase it to blead? It seems like people are cautiously enthusiastic about it.

demerphq avatar Feb 08 '23 07:02 demerphq

@Corion this ticket is stalled and in conflict. Do you have any intention to rebase it to blead? It seems like people are cautiously enthusiastic about it.

@Corion, ^^

jkeenan avatar Jul 31 '23 16:07 jkeenan

I'll look at it - thanks for keeping up with this!

Corion avatar Jul 31 '23 17:07 Corion

Rebased to current blead

Corion avatar Jul 31 '23 17:07 Corion

hi! is this like merged? (as in, sometimes commits get merged using git cli in a way that gh doesn't detect it)

goyalyashpal avatar Jan 02 '24 15:01 goyalyashpal

hi! is this like merged? (as in, sometimes commits get merged using git cli in a way that gh doesn't detect it)

No, it does not appear to have been merged. In fact, it has merge conflicts. @Corion, can you give us an update on the status of this pull request?

jkeenan avatar Jan 02 '24 16:01 jkeenan

Rebased. I think the two comments by @Leont still stand, but I can't promise that I can look into them. Maybe the rest should be applied and these two left out?

Corion avatar Jan 02 '24 16:01 Corion

hi! is this like merged? (as in, sometimes commits get merged using git cli in a way that gh doesn't detect it)

Somehow this work got spread over multiple tickets. There's some additional work here but I haven't cut it into clean patches yet.

Leont avatar Jan 02 '24 16:01 Leont