Perchun Pak
Perchun Pak
> To be clear, I do see that #335 exists and I still believe that the new code should land in its already planned future home. Why would we add...
> Indeed, we should not add more. I would like to fix it in specified for this place - #306. It would be worse to put it near `PingResponse` class...
> Why wait? Because if not follow current style, code will be messy more, than if we would follow the style. Even if it's ugly.
However, I will move this PR to #335. (oh wait, I did it already in `Motd.plain`...)
Not To Forget: Discuss and make backwards competitive.
> We should also consider adding both java and bedrock terms as properties in the base response classes. Java terms slight archaic, I saw many MOTD plugins and all of...
The only problem of my backport is different signature in `__init__` method. I tried do it with `typing.overwrite`, but it only produce more problems.
Maybe I made too many parametrizing, because at now in `master` there is **159** tests, and in this PR **425**.
I hope no one (@ItsDrike, @kevinkjt2000) forgot about this PR, because last my reminder was [in discord](https://discord.com/channels/936788458939224094/938623566964981802/982237445884104764), two weeks ago. And no activity since it.
Looks like last commits didn't run any CI, is this a bug? I also found one, when ran tests while resolving merge conflict. EDIT: Runs now, maybe just logs was...