Perchun Pak
Perchun Pak
Found something strange, when I read about the protocol, found that **all** text in MOTD can be formatted with one tag on top level. [See this.](https://wiki.vg/Chat#Inheritance) Should I implement parsing...
> **NOTE:** If this PR wasn't yet supposed to be reviewed, please mark it back as draft PR and feel free to ignore this review up until you think the...
I pretty sure, few big moments here still needs more work.
> [](https://minecraft.fandom.com/wiki/Raw_JSON_text_format#Java_Edition) Hmmmmmmm... I wonder, how many things was broken in [first implementation](https://github.com/py-mine/mcstatus/commit/b384f1b2ab844ba64c7bd3f016f4174dd1d22945) from Iapetus-11...
I do not remember what I wanted to improve here, so opening this for review.
> Perhaps it would be wise to do `parsed_motd.extend(cls._parse_as_string(text, bedrock))`, so that we'll actually parse out the colors in this text too. [Done!](https://github.com/py-mine/mcstatus/commit/23fce5624e161c5e389412b23cbbdb9c0898e8d2)
```py >>> status = JavaServer.lookup("hypixel.net").status() >>> status.description ' §aHypixel Network §c[1.8-1.19]\n §d§l3RD SKYBLOCK ANNIVERSARY' >>> status.description.clean() ' Hypixel Network [1.8-1.19]\n 3RD SKYBLOCK ANNIVERSARY' ```
> Looks good to go, though it may be nice to add some unit-tests before merging into master I'm sure, regex isn't a something, that should be tested. I firstly...
> Perhaps we should take this further and make a class dedicated to parsing Minecraft text. As I wrote in discord, this is just fast implement of one feature, that...
So it's approved, maybe merge it?