Smooth
Smooth copied to clipboard
Add new mono display
added SSD1306 I2C version fix build_test.sh update README.md
@enelson1001 Hey. I'm on vacation for another week, I'll have look at this afterwards.
Looks good, just wonder if all the changes in sdkonfig are just default values for a newer IDF?
Must be because I did not make changes to that file.
Yes, don't you think that is more organised that the current list?
On Wed, 11 Aug 2021, 05:04 enelson1001, @.***> wrote:
@.**** commented on this pull request.
In README.md https://github.com/PerMalmberg/Smooth/pull/163#discussion_r686457097:
@@ -64,12 +64,14 @@ If you are working on Windows or you don't want to install the dependencies on y - ILI9341 - ST7735 - SH1107
- SSD1306(I2C)
Are you saying do something like this spi |- display | - sensors
i2c |- display | sensors
etc?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/PerMalmberg/Smooth/pull/163#discussion_r686457097, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAU2LLAOREOY5DYQE23AOHLT4HSD5ANCNFSM5ARG2WMQ .
Yes that does sound better.
1.Do you think we should include rmt as one of the types and move RGBled under it?
2. Where would Weigand go?
3. Still keep tree with io and under it spi, i2c and rmt?
4. Under spi i2c rmt do we want additional folders like display, sensor, digital, analog, rtc, power mgt etc or just limp everything together?
- Sure, why not.
- It's own category, maybe? "Oddballs" :)
- If it adds something
- If it doesn't just clutter the list, sure.
I will start looking at what is involved to make this change this weekend. I will probably have a few more comments.
Per Please comment on the attached proposal before I begin working on this. PullReq163_ProposedChanges.pdf
thanks