Smooth icon indicating copy to clipboard operation
Smooth copied to clipboard

Add new mono display

Open enelson1001 opened this issue 3 years ago • 8 comments

added SSD1306 I2C version fix build_test.sh update README.md

enelson1001 avatar Jul 17 '21 16:07 enelson1001

@enelson1001 Hey. I'm on vacation for another week, I'll have look at this afterwards.

PerMalmberg avatar Jul 30 '21 06:07 PerMalmberg

Looks good, just wonder if all the changes in sdkonfig are just default values for a newer IDF?

PerMalmberg avatar Aug 07 '21 06:08 PerMalmberg

Must be because I did not make changes to that file.

enelson1001 avatar Aug 08 '21 13:08 enelson1001

Yes, don't you think that is more organised that the current list?

On Wed, 11 Aug 2021, 05:04 enelson1001, @.***> wrote:

@.**** commented on this pull request.

In README.md https://github.com/PerMalmberg/Smooth/pull/163#discussion_r686457097:

@@ -64,12 +64,14 @@ If you are working on Windows or you don't want to install the dependencies on y - ILI9341 - ST7735 - SH1107

  •  - SSD1306(I2C)
    

Are you saying do something like this spi |- display | - sensors

i2c |- display | sensors

etc?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/PerMalmberg/Smooth/pull/163#discussion_r686457097, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAU2LLAOREOY5DYQE23AOHLT4HSD5ANCNFSM5ARG2WMQ .

PerMalmberg avatar Aug 11 '21 04:08 PerMalmberg

Yes that does sound better.
1.Do you think we should include rmt as one of the types and move RGBled under it?
2. Where would Weigand go?
3. Still keep tree with io and under it spi, i2c and rmt?
4. Under spi i2c rmt do we want additional folders like display, sensor, digital, analog, rtc, power mgt etc or just limp everything together?

enelson1001 avatar Aug 13 '21 14:08 enelson1001

  1. Sure, why not.
  2. It's own category, maybe? "Oddballs" :)
  3. If it adds something
  4. If it doesn't just clutter the list, sure.

PerMalmberg avatar Aug 14 '21 05:08 PerMalmberg

I will start looking at what is involved to make this change this weekend. I will probably have a few more comments.

enelson1001 avatar Aug 17 '21 23:08 enelson1001

Per Please comment on the attached proposal before I begin working on this. PullReq163_ProposedChanges.pdf

thanks

enelson1001 avatar Aug 30 '21 15:08 enelson1001