nollup icon indicating copy to clipboard operation
nollup copied to clipboard

Published 20 hours ago • verified publisher icon PepsRyuu

Replace express-ws with ws

Open nacardin opened this issue 3 years ago • 3 comments

I need to proxy websocket connection to my backend. I was unable to use express-http-proxy or http-proxy along with express-ws. There was an error during the upgrade handshake. Handling the upgrade directly with ws fixes the issue. I also added the server object to the before and after since I needed it to handle the WS upgrade.

Thanks for reviewing!

nacardin avatar Jul 09 '21 17:07 nacardin

Looks good. I'll have a proper review as soon as I can! :)

PepsRyuu avatar Jul 09 '21 20:07 PepsRyuu

I had forgotten about updating the tests, it might take me some time to do that, so not ready for review yet. I'll update when I can.

nacardin avatar Jul 09 '21 21:07 nacardin

Went ahead with the removal of express-ws for ws in 0.18.0.

PepsRyuu avatar Jul 26 '21 16:07 PepsRyuu