pf_lidar_ros_driver icon indicating copy to clipboard operation
pf_lidar_ros_driver copied to clipboard

NaN range not filled in for packet type C

Open bk-mtg opened this issue 5 years ago • 2 comments

I haven't actually observed this in an operational setting, but I think this line that publishes NaN instead of the distance measurement only works for packet types A/B but not for packet type C. Not sure if it matters in practice since in any case it will be above the range_max parameter and should be ignored, but it seems generally undesirable to treat the various packet types differently. https://github.com/PepperlFuchs/ROS_driver/blob/477d72066f8cfc6ecb960fc388c2a8f0e9f6a3ec/pf_driver/src/ros/scan_publisher.cpp#L81-L82

bk-mtg avatar Jul 18 '20 01:07 bk-mtg

Is it addressed in https://github.com/PepperlFuchs/ROS_driver/pull/26?

hsd-dev avatar Aug 06 '20 08:08 hsd-dev

Not at present, no.

bk-mtg avatar Aug 17 '20 05:08 bk-mtg