Essentials icon indicating copy to clipboard operation
Essentials copied to clipboard

[FEATURE]-Samsung MDC Display provide current input feedback

Open ngenovese11 opened this issue 4 years ago • 4 comments

Is your feature request related to a problem? Please describe. From what I can tell, the Samsung MDC device only provides current input feedback reflecting power state. Could someone review and make sure I'm not missing something? I'm utilizing this device in a project and need to show current input selected.

Describe the solution you'd like Current input reflected on an analog input to the bridge.

ngenovese11 avatar Aug 12 '21 16:08 ngenovese11

We have a Samsung plugin that has been more maintained than the Essentials class. I'd use that plugin instead of the built-in functionality.

andrew-welker avatar Aug 12 '21 18:08 andrew-welker

I'm with @andrew-welker on this one - I feel like we should probably close this issue - but it does bring up the question of why we still maintain the samsung device within essentials when there's a more fully-functional plugin.

TrevorPayne avatar Mar 16 '22 04:03 TrevorPayne

I think it is marked as obsolete...and if it's not, it should be with a note to use the EPI. Most of the display classes that are in Essentials proper should be marked that way. We'll remove them in the next major version release.

andrew-welker avatar Mar 16 '22 04:03 andrew-welker

Is the Samsung plugin public?

Sent from my iPhone

On Mar 15, 2022, at 10:59 PM, Andrew Welker @.***> wrote:



I think it is marked as obsolete...and if it's not, it should be with a note to use the EPI. Most of the display classes that are in Essentials proper should be marked that way. We'll remove them in the next major version release.

— Reply to this email directly, view it on GitHubhttps://github.com/PepperDash/Essentials/issues/778#issuecomment-1068733708, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AENNGSFFAQKQUIHMSGVCTGLVAFTD7ANCNFSM5CBU655Q. You are receiving this because you are subscribed to this thread.Message ID: @.***>

ndorin avatar Mar 16 '22 14:03 ndorin

Is the Samsung plugin public?

Yes - the samsung plugin is public and is feature complete and (now) essentials compliant.

I would recommend closing this issue @jtalborough @ndorin

TrevorPayne avatar Feb 17 '23 06:02 TrevorPayne