Continuity icon indicating copy to clipboard operation
Continuity copied to clipboard

Port to 1.21.3

Open embeddedt opened this issue 1 year ago • 1 comments

Not very satisfied with the solution I used for storing the ModelWrappingHandler (stored it on ModelBaker, and added a passthrough implementation to BakerImpl). Everything else is pretty straightforward.

Ported this mostly for my own use; feel free to close if you've already done the work, I won't be offended.

embeddedt avatar Oct 28 '24 22:10 embeddedt

For your information, I think Pepper said that port 1.21.3 should no longer accept invalid characters, like OptiFIne see: https://github.com/sp614x/optifine/issues/7773

Lolothepro avatar Oct 31 '24 12:10 Lolothepro

I tried out this build in 1.21.3. Connected textures work fine, however emissive textures cause a game crash. Turning the setting off works as a bypass to the crash.

VitaminTree avatar Nov 10 '24 04:11 VitaminTree

Which resource pack did you use to test that? I had tried a basic emissive ores pack before making the PR and it seemed to work fine...

embeddedt avatar Nov 10 '24 12:11 embeddedt

My apologies, I hadn't thoroughly checked my mod folder and was still running Sodium with an unsupported version of Indium. I tested it without those and it seems to work fine. Again, sorry for the inconvenience.

VitaminTree avatar Nov 10 '24 15:11 VitaminTree

port 1.21.3 should no longer accept invalid characters

Where do you see invalid characters?

opalnext avatar Nov 11 '24 11:11 opalnext

how do i download this? Does it work without indium now?

AimzUnknown avatar Nov 12 '24 01:11 AimzUnknown

ETA?

Nilsson321 avatar Nov 12 '24 19:11 Nilsson321

@VitaminTree @AimzUnknown it looks like Indium isn't required anymore since Sodium says they support the Fabric Rendering API out of the box in the changelogs.

@AimzUnknown they probably built it themselves to test. You'd have to build the jar if you want a compiled version.

megabyte6 avatar Nov 17 '24 09:11 megabyte6

The initial port was completed in 1b31e2b.

PepperCode1 avatar Nov 26 '24 18:11 PepperCode1