Continuity icon indicating copy to clipboard operation
Continuity copied to clipboard

Emissive textures Z-fighting

Open antieksi opened this issue 2 years ago • 41 comments

изображение

The resourcepack containing emissive textures here is Glowing.

antieksi avatar Aug 01 '23 14:08 antieksi

I guess it can be seen better on a video.

https://i.imgur.com/v23d4HL.mp4

antieksi avatar Aug 01 '23 14:08 antieksi

I am also having the same issue, and with some testing I've found the z-fighting seems to occur on certain corners. The behaviour occurs on multiple packs with emissive textures.

A flat 5x5 plane: image

The same plane with a block placed in the center (z-fighting highlighted): image

DDunda avatar Aug 04 '23 02:08 DDunda

I have the same problem no other mods than Sodium Indium and Continuity

Wikinger8 avatar Aug 05 '23 19:08 Wikinger8

+1

I thought I was going insane and it was there the whole time. Seems its new!

JackiTacki avatar Aug 07 '23 17:08 JackiTacki

i think the newest indium update fixed the issue

Wikinger8 avatar Aug 07 '23 20:08 Wikinger8

I'll check!

JackiTacki avatar Aug 08 '23 12:08 JackiTacki

Doesnt seem like it. . .

JackiTacki avatar Aug 08 '23 12:08 JackiTacki

The issue is worse now, and different faces are affected. Up to three faces per corner can be affected. Emissive issue 2

It also interacts with light levels strangely (non-fighting blocks removed for clarity) Emissive issue 3

DDunda avatar Aug 09 '23 01:08 DDunda

The issue may be worsened by Sodium's compact vertex format. Regardless, it cannot really be fixed.

As a workaround, is possible to fix manually by removing pixels from the base texture that appear in the emissive texture, but this will cause those textures to look completely incorrect if emissive textures are disabled.

PepperCode1 avatar Aug 09 '23 01:08 PepperCode1

I just tried turning off smooth lighting and all Z-fighting stopped (including corner fighting), is that related to the vertex format?

DDunda avatar Aug 09 '23 01:08 DDunda

No.

PepperCode1 avatar Aug 09 '23 02:08 PepperCode1

Smooth Lighting is the weird cause of this, It seems. Turning it off makes it work fine, But the rest of the lighting then looks worse.

JackiTacki avatar Aug 09 '23 15:08 JackiTacki

As a workaround, is possible to fix manually by removing pixels from the base texture that appear in the emissive texture, but this will cause those textures to look completely incorrect if emissive textures are disabled.

adding to this for anyone doing such; blocks that naturally give off light seem to be unaffected (enchanting tables, crying obsidian, etc) it's strictly non-light blocks that cause the z-fighting, which helps to slightly reduce the load for editing bigger emissive packs

this can be best seen with redstone ore; when unlit z-fighting is present, though when lit it's as expected (no z-fighting)

notandvm avatar Aug 09 '23 18:08 notandvm

This issue used to not exist. It seems a sudden affliction.

JackiTacki avatar Aug 09 '23 18:08 JackiTacki

Until this situation gets resolved, 3D ore packs using emissives may be unuseable.

I found a way to keep the emissives without the 3d textures.

JackiTacki avatar Aug 09 '23 18:08 JackiTacki

As a workaround, is possible to fix manually by removing pixels from the base texture that appear in the emissive texture, but this will cause those textures to look completely incorrect if emissive textures are disabled.

Is it possible to not render those pixels that are covered with emissive texture? AND to do it only when emissive textures are enabled.

antieksi avatar Aug 09 '23 18:08 antieksi

This issue used to not exist. It seems a sudden affliction.

if i had to guess the recent sodium (& related (indium, iris)) updates caused it since downgrading back to previous versions leads to it being normal again

which isn't surprising given the sodium update broke a lot of mods, even some that you wouldn't expect like mod menu at least with what i've run into

notandvm avatar Aug 09 '23 18:08 notandvm

Hoping this gets fixed. . .

Im still having issues, And dont feel like having to use shaders constantly for ores. For now I'll just use Reimagined, But F for my FPS.

JackiTacki avatar Aug 09 '23 22:08 JackiTacki

Still could use an update on how to resolve this. . .

JackiTacki avatar Aug 19 '23 22:08 JackiTacki

Do we have any ideas as to what is causing the issue?

ItsSunnyMonster avatar Aug 19 '23 22:08 ItsSunnyMonster

Do we have any ideas as to what is causing the issue?

It appears to be related to smooth shading as the z-fighting stops when you disable it

DDunda avatar Aug 21 '23 10:08 DDunda

Confirmed. Smooth Lighting is the seeming cause

JackiTacki avatar Aug 23 '23 09:08 JackiTacki

Hopefully this can get a resolve. This is getting more annoying each time I have to deal with it. Sadge. . .

JackiTacki avatar Aug 25 '23 14:08 JackiTacki

Any updates?

ItsSunnyMonster avatar Sep 09 '23 22:09 ItsSunnyMonster

No

PepperCode1 avatar Sep 09 '23 22:09 PepperCode1

Yeesh. This may never get fixed. Depressing too. . .

JackiTacki avatar Sep 18 '23 11:09 JackiTacki

A video from a previous test.

https://github.com/PepperCode1/Continuity/assets/83630775/a45a23f5-b931-4113-9e2a-4c173876d6e9

7777777-4547 avatar Nov 12 '23 09:11 7777777-4547

This bug has been bugging me for quite some time. Any new information on this bug?

AlphaCraft9658 avatar Nov 26 '23 16:11 AlphaCraft9658

MoreMcmeta seems to have fixed this same issue in their emissive plugin. Might be worth checking how they worked around the issue. https://github.com/MoreMcmeta/emissive-plugin/issues/10

BlueJayofEvil avatar Nov 28 '23 04:11 BlueJayofEvil

I tried patching it by just removing the textures under the emissive layer manually and, uh... that didn't work lol

image

I hope to see an eventual real fix to this bug!

JuceInUse avatar Nov 29 '23 22:11 JuceInUse