Add user ldaps
Description
Module to add a new user to ldap, defaults to domain admins group, however user can pick group. Also defaults to username foobar with password P@ssw0rd!, user can pick username and password. User can also delete newly created user.
Type of change
Insert an "x" inside the brackets for relevant items (do not delete options)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Deprecation of feature or functionality
- [ ] This change requires a documentation update
- [ ] This requires a third party update (such as Impacket, Dploot, lsassy, etc)
Setup guide for the review
None, tested on GOAD, just an AD machine In particular:
- Added Feature/Enhancement: Please specify what setup is needed in order to test the changes. None
Screenshots (if appropriate):
Checklist:
Insert an "x" inside the brackets for completed and relevant items (do not delete options)
- [X] I have ran Ruff against my changes (via poetry:
poetry run python -m ruff check . --preview, use--fixto automatically fix what it can) - [X] I have added or updated the
tests/e2e_commands.txtfile if necessary (new modules or features are required to be added to the e2e tests) - [X] New and existing e2e tests pass locally with my changes
- [X] If reliant on changes of third party dependencies, such as Impacket, dploot, lsassy, etc, I have linked the relevant PRs in those projects
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation (PR here: https://github.com/Pennyw0rth/NetExec-Wiki)
Thanks for the PR!
We should probably wait for https://github.com/Pennyw0rth/NetExec/pull/843 to be merged so we have a standard version of creating ldap3 connection objects. Also the PR is partially duplicate to https://github.com/Pennyw0rth/NetExec/pull/688. Not sure yet what the best way is to handle that.