NetExec icon indicating copy to clipboard operation
NetExec copied to clipboard

remove old server code unused

Open mpgn opened this issue 8 months ago • 2 comments

Description

This pull request removes the NXCSMBServer class and its associated functionality from the codebase, simplifying the SMB-related code. The changes include the removal of the server implementation, decorator, and imports referencing this functionality.

Removal of NXCSMBServer functionality:

  • nxc/servers/smb.py: Fully removed the NXCSMBServer class, which implemented a custom SMB server, along with its imports and threading logic.

  • nxc/protocols/smb.py: Deleted the requires_smb_server decorator, which previously managed the lifecycle of the NXCSMBServer instance, and removed related imports. [1] [2]

Cleanup of references to removed functionality:

  • netexec.spec: Removed the reference to nxc.servers.smb from the analysis configuration, reflecting the removal of the NXCSMBServer implementation.

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)

mpgn avatar Apr 26 '25 17:04 mpgn

Highly appreaciated! This is also ancient stuff. Can you also rip out on_response/on_request in the example module and the smb.py module logic?

NeffIsBack avatar Apr 26 '25 23:04 NeffIsBack

Highly appreaciated! This is also ancient stuff. Can you also rip out on_response/on_request in the example module and the smb.py module logic?

done ✅

mpgn avatar Apr 27 '25 08:04 mpgn