NetExec icon indicating copy to clipboard operation
NetExec copied to clipboard

ssh module refactoring separate auth/shell checks

Open nikaiw opened this issue 1 year ago • 1 comments

This pull request aims to refactor the code to make it more readable but also to properly separate the code that can be linked to authentication from the code linked to the test concerning the shell obtained

nikaiw avatar Jun 02 '24 17:06 nikaiw

While we are at it we should probably also catch the timeout error in #358.

NeffIsBack avatar Sep 01 '24 21:09 NeffIsBack

@nikaiw any update on this?

NeffIsBack avatar Nov 15 '24 22:11 NeffIsBack

hello @NeffIsBack sorry this was sitting in my dev folder for a while. I'm not sure what I wanted to double check before commiting

nikaiw avatar Nov 16 '24 23:11 nikaiw

While i think the current implementation is not ideal, this PR introduces way too many problems with private key authentication, which work in the main branch. I tried fixing them in the last hour, but at this point i will need to refactor the implementation anyways.

I will continue working on ssh in #531, but closing this one for now. Still thanks for your work, i will implement some ideas in the new PR!

NeffIsBack avatar Jan 02 '25 21:01 NeffIsBack