NetExec icon indicating copy to clipboard operation
NetExec copied to clipboard

Published 20 hours ago • verified publisher icon Pennyw0rth

refactoring of the ssh module to separate auth check / cmd checks

Open nikaiw opened this issue 9 months ago • 6 comments

nikaiw avatar May 07 '24 11:05 nikaiw

Thanks fot the contribution! Fyi, i changed the target branch to main

NeffIsBack avatar May 07 '24 11:05 NeffIsBack

@nikaiw can you undo the black formatting?

Marshall-Hallenbeck avatar May 07 '24 13:05 Marshall-Hallenbeck

should be better I hope

nikaiw avatar May 07 '24 14:05 nikaiw

Thanks for the work 🙂

mpgn avatar May 07 '24 17:05 mpgn

@nikaiw can you run Ruff and fix any issues? poetry run python -m ruff check . --preview (--fix will autofix anything it can)

Marshall-Hallenbeck avatar May 10 '24 19:05 Marshall-Hallenbeck

@Marshall-Hallenbeck yes, done. Sry actually I did it previously but I guess not with the latest ruff version. It should be better now

nikaiw avatar May 10 '24 23:05 nikaiw

@nikaiw it looks like this is based of the old dev branch and is therefore quite outdated. Could you either resolve the conflicts or reopen the PR with the new changes applied to the latest commits of the main branch? image

NeffIsBack avatar Jun 01 '24 22:06 NeffIsBack

Fyi: gonna close this PR in favour of #331

NeffIsBack avatar Jun 14 '24 20:06 NeffIsBack