NetExec icon indicating copy to clipboard operation
NetExec copied to clipboard

WCC Module Creating Arbitrary Empty Log Files

Open Marshall-Hallenbeck opened this issue 10 months ago • 2 comments

Describe the bug The WCC module has some custom logging code that creates a ton of empty log files

To Reproduce Run the WCC module Command: netexec smb -u username -p password -M wcc

Expected behavior Log files should have actual data in them, or they shouldn't be created

Screenshots image

NetExec info

  • OS: Kali
  • Version of nxc: 1.1.0 - nxc4u - b123a4dc
  • Installed from: main branch, via poetry

Additional context I think we should implement a way for any module/etc to create specific logs to their needs, i.e. if a module wants to log something for users to look up later, like files created/hashes/etc, we should have an easy logging method outside our context.log/nxc_logger

Marshall-Hallenbeck avatar Apr 13 '24 17:04 Marshall-Hallenbeck

Ohhh since we import the modules every nxc run it's creating the logger file EACH TIME NXC IS RAN. Definitely going to be at least fixing that shortly.

Marshall-Hallenbeck avatar May 15 '24 17:05 Marshall-Hallenbeck

Oh god. But atleast nxc only imports all modules when -L or a specific module is specified.

But a fix would be really nice, it's anyway a bit whack

NeffIsBack avatar May 15 '24 18:05 NeffIsBack