pennylane icon indicating copy to clipboard operation
pennylane copied to clipboard

Make `CommutingEvolution` a `SymbolicOp`

Open dwierichs opened this issue 9 months ago • 4 comments

Context: CommutingEvolution has the structure of a ScalarSymbolicOp, so we make it one.

Description of the Change: Change base class of CommutingEvolution and adapt other attributes of the class to this change.

In addition, a dispatch branch of qml.equal for all ScalarSymbolicOps is introduced.

Benefits: Code quality

Possible Drawbacks:

Related GitHub Issues:

dwierichs avatar May 13 '24 09:05 dwierichs

Hello. You may have forgotten to update the changelog! Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

github-actions[bot] avatar May 13 '24 09:05 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.67%. Comparing base (5b81a8a) to head (5b6da65). Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5682      +/-   ##
==========================================
- Coverage   99.68%   99.67%   -0.01%     
==========================================
  Files         415      415              
  Lines       38886    38602     -284     
==========================================
- Hits        38762    38477     -285     
- Misses        124      125       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 16 '24 20:05 codecov[bot]

@dwierichs? Do we have a story for this PR? If so, please could you link? It makes it easier to track where things sit in the roadmap.

trbromley avatar Jul 29 '24 13:07 trbromley

@trbromley I don't think we have a story, because this PR came out of exploratory work for [sc-61425]. I don't know whether we are still interested in making this one happen?

dwierichs avatar Jul 29 '24 13:07 dwierichs