pennylane icon indicating copy to clipboard operation
pennylane copied to clipboard

Improve support for interfaces with `dynamic_one_shot`

Open mudit2812 opened this issue 1 year ago • 1 comments

Before submitting

Please complete the following checklist when submitting a PR:

  • [ ] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the test directory!

  • [ ] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running make docs.

  • [ ] Ensure that the test suite passes, by running make test.

  • [ ] Add a new entry to the doc/releases/changelog-dev.md file, summarizing the change, and including a link back to the PR.

  • [ ] The PennyLane source code conforms to PEP8 standards. We check all of our code against Pylint. To lint modified files, simply pip install pylint, and then run pylint pennylane/path/to/file.py.

When all the above are checked, delete everything above the dashed line and fill in the pull request template.


Context: Opened in favour of #5630. Bug fix for #5442.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

mudit2812 avatar May 08 '24 20:05 mudit2812

Should 59938 be the relevant SC story here?

trbromley avatar May 10 '24 13:05 trbromley

[sc-59938]

mudit2812 avatar May 14 '24 18:05 mudit2812

Hello. You may have forgotten to update the changelog! Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

github-actions[bot] avatar May 15 '24 20:05 github-actions[bot]

I will keep iterating with changing the number of shots/seed until the tests pass, but otherwise this should be good to go.

mudit2812 avatar May 16 '24 21:05 mudit2812

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.67%. Comparing base (fbc2a39) to head (7d1915d). Report is 252 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5672      +/-   ##
==========================================
- Coverage   99.68%   99.67%   -0.01%     
==========================================
  Files         416      416              
  Lines       39105    38815     -290     
==========================================
- Hits        38981    38690     -291     
- Misses        124      125       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 24 '24 22:05 codecov[bot]