pennylane icon indicating copy to clipboard operation
pennylane copied to clipboard

Expand the qml.from_qiskit docs

Open lillian542 opened this issue 11 months ago • 3 comments

document all the things

lillian542 avatar Feb 26 '24 03:02 lillian542

Hello. You may have forgotten to update the changelog! Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

github-actions[bot] avatar Feb 26 '24 03:02 github-actions[bot]

[sc-57149]

lillian542 avatar Feb 26 '24 03:02 lillian542

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (v0.35.0-rc0@c1f3997). Click here to learn what that means.

Additional details and impacted files
@@              Coverage Diff               @@
##             v0.35.0-rc0    #5259   +/-   ##
==============================================
  Coverage               ?   99.65%           
==============================================
  Files                  ?      399           
  Lines                  ?    36601           
  Branches               ?        0           
==============================================
  Hits                   ?    36473           
  Misses                 ?      128           
  Partials               ?        0           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 26 '24 03:02 codecov[bot]

Thanks for the review, @trbromley! I've replied to your suggestions and made some additional changes.

Mandrenkov avatar Feb 28 '24 20:02 Mandrenkov

Any worries about 7d05c63f69eb8ab364a11b2bc49027d2cefc0c30? We could always create a new PR since the changes here are pretty localized, if we're worried about a polluted branch.

trbromley avatar Feb 28 '24 21:02 trbromley

Thanks for taking another look, @trbromley!

Any worries about 7d05c63? We could always create a new PR since the changes here are pretty localized, if we're worried about a polluted branch.

Yeah, it may be cleaner to just make a new branch and apply the changes by hand. I'll open up a new PR and link it here.

Mandrenkov avatar Feb 28 '24 21:02 Mandrenkov

Closed in favour of #5279.

Mandrenkov avatar Feb 28 '24 22:02 Mandrenkov