pennylane icon indicating copy to clipboard operation
pennylane copied to clipboard

trim lightning dev version in stable deps

Open timmysilv opened this issue 1 year ago • 1 comments

Context: Every time there's a new merge to lightning master, the version on the test PyPI repo gets bumped. This causes noisy commits like this one for test suites that use the latest master version of lightning. The versions look something like "PennyLane_Lightning==0.35.0.dev16", so we'd see a bump from dev16 to dev17. See this commit as an example of this change in action.

Description of change: Always trim lightning dev versions to just say dev, instead of devx. That way, we know that it's a dev install, but we don't get bothered whenever there's a new merge to master.

Possible drawbacks: We might want to know exactly which dev version of lightning is installed, but if it's due to a recent issue, we could probably figure it out anyway...

timmysilv avatar Feb 23 '24 22:02 timmysilv

Hello. You may have forgotten to update the changelog! Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

github-actions[bot] avatar Feb 23 '24 22:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.65%. Comparing base (ae96c62) to head (bb509f8). Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5254      +/-   ##
==========================================
- Coverage   99.65%   99.65%   -0.01%     
==========================================
  Files         399      399              
  Lines       36901    36615     -286     
==========================================
- Hits        36774    36487     -287     
- Misses        127      128       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 27 '24 14:02 codecov[bot]

It would be nice to test out any changes to the command before merging!

Mandrenkov avatar Feb 28 '24 19:02 Mandrenkov

I have updated it accordingly.

  • aded the g and I flags for global and case-insensitive matching
  • included the full package name
  • had to keep the trailing digits otherwise they'd be added afterwards

timmysilv avatar Feb 28 '24 20:02 timmysilv

here's a commit triggered by this branch to validate that it works

timmysilv avatar Feb 28 '24 20:02 timmysilv