pennylane icon indicating copy to clipboard operation
pennylane copied to clipboard

[Return-types #5.3] Param-shift shot vector case

Open antalszava opened this issue 2 years ago • 2 comments

Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

antalszava avatar Sep 21 '22 21:09 antalszava

Hello. You may have forgotten to update the changelog! Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

github-actions[bot] avatar Sep 21 '22 21:09 github-actions[bot]

Codecov Report

Merging #3099 (acebd44) into master (351c6bd) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3099   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files         275      275           
  Lines       23944    24011   +67     
=======================================
+ Hits        23870    23937   +67     
  Misses         74       74           
Impacted Files Coverage Δ
pennylane/gradients/finite_difference.py 100.00% <100.00%> (ø)
pennylane/gradients/parameter_shift.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 21 '22 21:09 codecov[bot]

my above comments are all pretty small, this PR looks great! updating that test file was a true feat 😸

timmysilv avatar Oct 19 '22 17:10 timmysilv

@timmysilv @rmoyard thanks for the great comments! :tada:

I think I've addressed them all, some with questions - keen to get further thoughts. :+1: Let me know what should definitely change still in this PR.

antalszava avatar Oct 20 '22 21:10 antalszava