pennylane icon indicating copy to clipboard operation
pennylane copied to clipboard

[WIP][Return-types Fix #3] Update `.shape` and `.numeric_type` attribute for `QuantumTape`

Open eddddddy opened this issue 2 years ago • 2 comments

Before submitting

Please complete the following checklist when submitting a PR:

  • [ ] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the test directory!

  • [ ] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running make docs.

  • [ ] Ensure that the test suite passes, by running make test.

  • [ ] Add a new entry to the doc/releases/changelog-dev.md file, summarizing the change, and including a link back to the PR.

  • [ ] The PennyLane source code conforms to PEP8 standards. We check all of our code against Pylint. To lint modified files, simply pip install pylint, and then run pylint pennylane/path/to/file.py.

When all the above are checked, delete everything above the dashed line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

eddddddy avatar Sep 21 '22 19:09 eddddddy

Hello. You may have forgotten to update the changelog! Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

github-actions[bot] avatar Sep 21 '22 19:09 github-actions[bot]

Codecov Report

Merging #3098 (259d51b) into master (8df972b) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3098   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files         273      273           
  Lines       23683    23750   +67     
=======================================
+ Hits        23609    23676   +67     
  Misses         74       74           
Impacted Files Coverage Δ
pennylane/measurements.py 100.00% <100.00%> (ø)
pennylane/tape/tape.py 99.38% <100.00%> (+0.02%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 21 '22 20:09 codecov[bot]

Hi @rmoyard, I updated the relevant code in the jax-jit interface here. I didn't include that code in this PR because it is out of scope.

eddddddy avatar Oct 12 '22 21:10 eddddddy

Amazing @eddddddy 💯

rmoyard avatar Oct 12 '22 21:10 rmoyard