pennylane-lightning icon indicating copy to clipboard operation
pennylane-lightning copied to clipboard

[WIP] Get site_packages path with pybind11 API in C++ backend

Open multiphaseCFD opened this issue 1 year ago • 3 comments
trafficstars

Before submitting

Please complete the following checklist when submitting a PR:

  • [ ] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the tests directory!

  • [ ] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running make docs.

  • [ ] Ensure that the test suite passes, by running make test.

  • [ ] Add a new entry to the .github/CHANGELOG.md file, summarizing the change, and including a link back to the PR.

  • [ ] Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed line and fill in the pull request template.


[SC-53754] Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

multiphaseCFD avatar Apr 26 '24 22:04 multiphaseCFD

Hello. You may have forgotten to update the changelog! Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

github-actions[bot] avatar Apr 26 '24 22:04 github-actions[bot]

Codecov Report

Attention: Patch coverage is 97.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.06%. Comparing base (83ac9d8) to head (77a8b21).

Files Patch % Lines
..._lightning/core/src/utils/BLASLibLoaderManager.hpp 95.91% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #701      +/-   ##
==========================================
- Coverage   95.11%   95.06%   -0.06%     
==========================================
  Files         113       74      -39     
  Lines       18153    11524    -6629     
==========================================
- Hits        17267    10955    -6312     
+ Misses        886      569     -317     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 26 '24 23:04 codecov[bot]

Home/.local/ libs are missing when I tested catalyst against PR#701, which leads to the failures in Catalyst tests. I found that this is an issue created in the pybind11 repo here.

multiphaseCFD avatar May 07 '24 22:05 multiphaseCFD