catalyst
catalyst copied to clipboard
[Frontend] Fix decomposition tests
Context: Recent changes in the TOML files broke some tests.
Description of the Change: Fix those tests.
Benefits: Latest/latest/latest passes again (at least for lightning.qubit).
Comment:
The minimum version of pennylane-lightning required is 0.37.0-dev7 but those wheels failed to be uploaded. I have used 0.37.0-dev9. If the minimum version required is required for this PR, let me know and I will ask the team to push wheels for -dev7
[sc-63376]
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.08%. Comparing base (
0dc7538) to head (02a2211). Report is 302 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #745 +/- ##
==========================================
- Coverage 98.10% 98.08% -0.03%
==========================================
Files 69 69
Lines 9550 9550
Branches 746 746
==========================================
- Hits 9369 9367 -2
- Misses 147 148 +1
- Partials 34 35 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hello. You may have forgotten to update the changelog!
Please edit doc/changelog.md on your branch with:
- A one-to-two sentence description of the change. You may include a small working example for new features.
- A link back to this PR.
- Your name (or GitHub username) in the contributors section.
I'm not sure how much of this PR is clashing with #718 and #712, could you double check?
I'm not sure how much of this PR is clashing with https://github.com/PennyLaneAI/catalyst/pull/718 and https://github.com/PennyLaneAI/catalyst/pull/712, could you double check?
I'm happy to close this PR without merging if #718 and #712 would fix latest/latest/latest.
I'm not sure how much of this PR is clashing with #718 and #712, could you double check?
I'm happy to close this PR without merging if #718 and #712 would fix latest/latest/latest.
We need #712 . I would suggest to merge it instead of this PR. #712 addresses exactly this issue, but in my opinion - in a more systematic way: it adds an option to modify capabilities directly so we no longer need to stick to a particular toml syntax in tests.
The #718 fixes another toml leftover, it requires #712 as a prerequisite.
I'm not sure how much of this PR is clashing with #718 and #712, could you double check?
I'm happy to close this PR without merging if #718 and #712 would fix latest/latest/latest.
We need #712 . I would suggest to merge it instead of this PR. #712 addresses exactly this issue, but in my opinion - in a more systematic way: it adds an option to modify capabilities directly so we no longer need to stick to a particular toml syntax in tests.
The #718 fixes another toml leftover, it requires #712 as a prerequisite.
Let's give those PRs the final push! @grwlf can you ensure relevant discussions are resolved with the reviewers and merged this week?
@dime10 and @grwlf just commenting that this is probably no longer required, right?
@dime10 and @grwlf just commenting that this is probably no longer required, right?
Probably not 👍