catalyst icon indicating copy to clipboard operation
catalyst copied to clipboard

[Runtime] Add support for Lightning source directory to be used in runtime build

Open mlxd opened this issue 1 year ago • 3 comments

Context: This PR allows Lightning to be cloned and used in-place with Catalyst's runtime, allowing faster turnaround and development against both packages. In addition, it overcomes some issues with Python package issues observed at build time by updating the runtime pybind11 and requiring Python to be found before proceeding.<\del>

Description of the Change: Added LIGHTNING_SRC_PATH CMake argument to specify a full path to a local Lightning repository, and all source will be used in place for a runtime build.

Benefits: Enables faster turnaround for development between Lightning and Catalyst. Can allow a multi-version clone of each repo and compilation steps to be validated and tested.

Possible Drawbacks:

Related GitHub Issues:

mlxd avatar May 10 '24 19:05 mlxd

[sc-63110]

mlxd avatar May 10 '24 19:05 mlxd

Hello. You may have forgotten to update the changelog! Please edit doc/changelog.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

github-actions[bot] avatar May 10 '24 19:05 github-actions[bot]

Exploring whether https://github.com/PennyLaneAI/pennylane-lightning/pull/725/ will fix Kokkos failures

UPDATE: No further LK issues.

mlxd avatar May 10 '24 20:05 mlxd

Happy to approve 💯 Would love to figure the pybind/findpython issue at some point though if you have time.

Sounds good. Yea, I'll do some delving once time permits.

mlxd avatar May 17 '24 18:05 mlxd