catalyst icon indicating copy to clipboard operation
catalyst copied to clipboard

Enable warnings as error in Python & C++ layer tests

Open mlxd opened this issue 1 year ago • 3 comments

Before submitting

Please complete the following checklist when submitting a PR:

  • [ ] All new functions and code must be clearly commented and documented.

  • [ ] Ensure that code is properly formatted by running make format. The latest version of black and clang-format-14 are used in CI/CD to check formatting.

  • [ ] All new features must include a unit test. Integration and frontend tests should be added to frontend/test, Quantum dialect and MLIR tests should be added to mlir/test, and Runtime tests should be added to runtime/tests.

When all the above are checked, delete everything above the dashed line and fill in the pull request template.


Context: This PR adds a clang-tidy GH Action that runs at a predefined weekly periodicity, with all warnings promoted to errors. In addition, we add promotions to the runtime warning checks to errors by default when running directly from the Makefile.

Description of the Change: As above.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

mlxd avatar Sep 04 '24 22:09 mlxd

Hello. You may have forgotten to update the changelog! Please edit doc/releases/changelog-dev.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

github-actions[bot] avatar Sep 13 '24 18:09 github-actions[bot]

Closing in favour of #1588

mlxd avatar Mar 27 '25 19:03 mlxd

Reopening to add support for clang-tidy with WAE

mlxd avatar Mar 28 '25 21:03 mlxd