catalyst
catalyst copied to clipboard
Enable warnings as error in Python & C++ layer tests
Before submitting
Please complete the following checklist when submitting a PR:
-
[ ] All new functions and code must be clearly commented and documented.
-
[ ] Ensure that code is properly formatted by running
make format. The latest version of black andclang-format-14are used in CI/CD to check formatting. -
[ ] All new features must include a unit test. Integration and frontend tests should be added to
frontend/test, Quantum dialect and MLIR tests should be added tomlir/test, and Runtime tests should be added toruntime/tests.
When all the above are checked, delete everything above the dashed line and fill in the pull request template.
Context: This PR adds a clang-tidy GH Action that runs at a predefined weekly periodicity, with all warnings promoted to errors. In addition, we add promotions to the runtime warning checks to errors by default when running directly from the Makefile.
Description of the Change: As above.
Benefits:
Possible Drawbacks:
Related GitHub Issues:
Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md on your branch with:
- A one-to-two sentence description of the change. You may include a small working example for new features.
- A link back to this PR.
- Your name (or GitHub username) in the contributors section.
Closing in favour of #1588
Reopening to add support for clang-tidy with WAE