PengZheng

Results 75 comments of PengZheng

You could try something small first, like fix issues of a specific bundle and add corresponding error injection tests to make sure your changes are covered by unit tests. Your...

I'll finish reviewing it this week.

> Should we also add clang-tidy to our CI? Yes. > For the usage of '(void)' for an explicit empty argument list, maybe this should also be added to our...

Yeah, it seems that `LD_LIBRARY_PATH` is not properly set. Conan generates a script under the build directory to do it ``` cd build source conanrun.sh ctest --output-on-failure source deactivate_conanrun.sh ```

Currently @xuzhenbao, who happens to be a CLion user, is investigating #783. When it is done, we can update our documentation to add a guide. @rlenferink WDYT?